Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Fix OS X resource fork handling (Reported-by: Richard O'Keefe) #299

Merged
merged 1 commit into from Jul 25, 2014
Merged

Fix OS X resource fork handling (Reported-by: Richard O'Keefe) #299

merged 1 commit into from Jul 25, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jun 17, 2014

If you happen to fetch a zip archive of the git repo and try to build
from that, you may, for example, ask erlc to build src/._rebar.erl.
._* are OS X resource forks and not real .erl files. This may also
happen with network filesystems on OS X. To fix that, limit the
files compiled by rebar to include only those which start with
a letter or a digit.

@ghost
Copy link
Author

ghost commented Jun 17, 2014

inttest/depplugins fails. will look into it.

@ferd
Copy link
Contributor

ferd commented Jun 17, 2014

Have you considered looking at the fix José Valim recommended on the list? I'm not sure if it worked pre-R15B? http://erlang.org/pipermail/erlang-questions/2014-June/079608.html

It sounds like a decent way to get it working safely. Not sure about speed though.

@ferd ferd added the bug label Jun 17, 2014
@ghost
Copy link
Author

ghost commented Jun 17, 2014

@ferd wrote:

Have you considered looking at the fix Jose Valim recommended on the list? I'm not sure if it worked pre-R15B? http://erlang.org/pipermail/erlang-questions/2014-June/079608.html

It sounds like a decent way to get it working safely. Not sure about speed though.

That would only work in bootstrap as rebar_utils:find_files uses filelib:fold_files. Also, the alternative wildcard/2 approach is undocumented as far as I can see, and we can only rely on it if the OTP team accepts a patch to document it in a future release.

If you happen to fetch a zip archive of the git repo and try to build
from that, you may, for example, ask erlc to build src/._rebar.erl.
._* are OS X resource forks and not real .erl files. This may also
happen with network filesystems on OS X. To fix that, limit the
files compiled by rebar to include only those which start with
a letter or a digit.
tsloughter added a commit that referenced this pull request Jul 25, 2014
Fix OS X resource fork handling (Reported-by: Richard O'Keefe)
@tsloughter tsloughter merged commit 19c215e into rebar:master Jul 25, 2014
@ghost ghost deleted the rok-resource-forks branch July 25, 2014 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants