Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Fix cover print truncation when coverage is 100% #371

Merged
merged 1 commit into from
Oct 16, 2014

Conversation

ferd
Copy link
Contributor

@ferd ferd commented Oct 16, 2014

When the option {cover_print_enabled, true} is set and that the code
coverage is 100%, the '%' will end up being truncated.

This patch makes it so that the truncation happens at 4 a characters
width so that instead of the following printouts:

some_mod  : 99%
some_other: 100

We instead show:

some_mod  :  99%
some_other: 100%

This solves issue #331 as reported by @lispking and @NineFX.

When the option {cover_print_enabled, true} is set and that the code
coverage is 100%, the '%' will end up being truncated.

This patch makes it so that the truncation happens at 4 a characters
width so that instead of the following printouts:

    some_mod  : 99%
    some_other: 100

We instead show:

    some_mod  :  99%
    some_other: 100%

This solves issue #331 as reported by @lispking and @NineFX.
@ferd
Copy link
Contributor Author

ferd commented Oct 16, 2014

@Tuncer if you want to rubberstamp this one to avoid having me unilaterally moving my own patches in, that would be cool. It's minor stuff, literally a one-character change.

@ghost
Copy link

ghost commented Oct 16, 2014

I'm not sure what "to rubberstamp" means, but this looks good to me.

@ferd
Copy link
Contributor Author

ferd commented Oct 16, 2014

It as in jest:

to give approval automatically or without consideration: to rubber-stamp the president's proposals.

Thanks for the review!

ferd added a commit that referenced this pull request Oct 16, 2014
Fix cover print truncation when coverage is 100%
@ferd ferd merged commit b693c23 into rebar:master Oct 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants