Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Fix/remove duplicate console message #408

Merged
merged 1 commit into from
Dec 21, 2014

Conversation

lrascao
Copy link
Contributor

@lrascao lrascao commented Dec 20, 2014

No description provided.

@ghost
Copy link

ghost commented Dec 20, 2014

Can you please make the following minor changes?

  1. rebase cleanly against master (maybe git reset --hard origin/master && git cherry-pick 6bba389 followed by git commit --amend for the commit message fix)
  2. fix the commit message to properly follow CONTRIBUTING

before

remove duplicate compiling message

unnecessary since base compiler already prints a message to the effect

after

gpb_compiler: remove duplicate compiling message

It's unnecessary to print "Compiling..." since base_compiler already prints a
message to the effect.

@ghost ghost mentioned this pull request Dec 20, 2014
It's unnecessary to print "Compiling..." since base_compiler already prints a
message to the effect.
@lrascao lrascao force-pushed the fix/remove_duplicate_console_message branch from 6bba389 to 5bb7b29 Compare December 21, 2014 16:09
@lrascao
Copy link
Contributor Author

lrascao commented Dec 21, 2014

@Tuncer, done

@ghost
Copy link

ghost commented Dec 21, 2014

ping @ferd @tsloughter?

ferd added a commit that referenced this pull request Dec 21, 2014
…sage

Fix/remove duplicate console message
@ferd ferd merged commit 8f64e13 into rebar:master Dec 21, 2014
lrascao added a commit to lrascao/rebar that referenced this pull request Dec 22, 2014
Conjunction of pull requests rebar#386 and rebar#408 (8f64e1, 81063d) led to compilation message being removed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants