Fixed #133. Release upgrade now handle long and short names properly.

[seriyps]

Implemented, by moving upgrade installation from install_upgrade.escript to nodetool, which already supports both short and long names.

See https://github.com/rebar/rebar/issues/133#issuecomment-69211063 for details.

I've tested this version on my project and it works nice. No tests (make test) were broken.

[ghost]

+1

[ferd]

Just to be clear, that's a backwards incompatible change over the current tooling we provide, isn't it?

[ghost]

Yes, as the functionality is moved into a sub-command of nodetool. Do you think install_upgrade.escript should be modified to call nodetool upgrade with maybe a deprecation message?

[ferd]

Either that or just left there for compatibility reasons. Otherwise we'll have to go a full deprecation cycle on this PR.

[seriyps]

So, should I add some wrapper to this PR, as @Tuncer suggests?

[ferd]

Yeah. That way we'd maintain backwards compatibility as much as possible. Is there anything else you'd expect to break or change for someone using the script?

[seriyps]

No, I'll just add a wrapper for nodetool, which will follow original install_upgrade.escript API and will show warning message and then delegate all the work to nodetool via, say, os:cmd or open_port. Nothing else should be broken.

[ferd]

Then that sounds good.

[seriyps]

@ferd maybe I should also add comment about deprecation to {copy, "files/install_upgrade.escript", "bin/install_upgrade.escript"} line in default reltool.config?

[ferd]

Yeah. That one would be needed. In practice I don't know if this will be considered breaking or not, if existing configs suddenly stop working because we don't copy the file install_upgrade.escript needs to work under the new code with an old config.

It would be extremely annoying to deploy a node/release and then when you need to operate on it, suddenly realize the scripts don't work because someone upgraded rebar on the build server.

[seriyps]

@ferd ok, I've just added backward-compatible install_upgrade.escript as a wrapper for nodetool.

[ferd]

Alright, with the rebasing stuff looks like it still passes. I'm in for the backwards compatible script. @Tuncer any last thing before I merge this in?

[ghost]

I would put the comment on a separate (previous) line for readability.

[seriyps]

@Tuncer fixed in ab4c20f

[ghost]

Thanks, the new version has to use %% though, and it should be indented like the surrounding lines.

[ghost]

Also, it's best to squash the fixup commits into the original commit.

[seriyps]

@Tuncer comment fixed and all commits squashed to one.