This repository has been archived by the owner on May 12, 2018. It is now read-only.
simplenode.reltool.config: use default sys-level mod_cond setting #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Less happy about the current patch. People will uncomment it thinking it's safe and then find out their release won't work and unless they really know reltool they won't know how to make it work. It's not a magical option you can change to make the release smaller, there's a lot more to it than that. Either remove entirely or just leave |
|
+1 |
|
@essen amended the commit to completely remove the non-default sys-level mod_cond and did the same in https://github.com/rebar/rebar/wiki/Release-handling. Also see http://erlang.org/pipermail/erlang-questions/2013-April/073185.html |
As discussed here http://erlang.org/pipermail/erlang-questions/2012-December/071135.html change the reltool spec to use the default sys-level mod_cond setting.
dizzyd
added a commit
that referenced
this pull request
Apr 10, 2013
simplenode.reltool.config: use default sys-level mod_cond setting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here change the reltool spec to use the default sys-level mod_cond setting.