Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

added 'shell' command to bash-completion #452

Merged
merged 1 commit into from
Feb 15, 2015
Merged

added 'shell' command to bash-completion #452

merged 1 commit into from
Feb 15, 2015

Conversation

yannayl
Copy link
Contributor

@yannayl yannayl commented Feb 12, 2015

updated the bash shell auto-completion to complete the 'rebar shell' command

@ghost
Copy link

ghost commented Feb 12, 2015

Thanks.

Please:

  1. Change the commit message according to CONTRIBUTING#writing-commit-messages: added -> Add, updated -> Update, and terminate the description (not the summary) with a period.
  2. Append your name in THANKS

Also, if you want to, you can add the missing entry in the zsh completion script as well.

@yannayl
Copy link
Contributor Author

yannayl commented Feb 12, 2015

Welcome.

  1. Done (commit amend).
  2. Will be done when I contribute something a little bit more significant :-)

Sorry, but I am not zsh user and don't understand the syntax of the completion file (I tried, but don't have time to study it right now).

@ghost
Copy link

ghost commented Feb 12, 2015

Thanks, but since the rewritten commit description just duplicates the summary, you can omit that or restore the previous text. As there's no explanation required, I'd say omit the description.

Here's the zsh patch: #453.

@yannayl
Copy link
Contributor Author

yannayl commented Feb 13, 2015

ok.

I merged your patch into mine and committed again.

@ghost ghost mentioned this pull request Feb 13, 2015
@ghost
Copy link

ghost commented Feb 13, 2015

+1

ferd added a commit that referenced this pull request Feb 15, 2015
added 'shell' command to bash-completion
@ferd ferd merged commit f562683 into rebar:master Feb 15, 2015
@yannayl yannayl deleted the patch-1 branch April 2, 2015 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants