-
Notifications
You must be signed in to change notification settings - Fork 296
Conversation
"rebar-cover_compile_opts.config"}]. | ||
|
||
run(Dir) -> | ||
io:format("run(~p)~n",[Dir]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this use retest_log instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Actually, it probably should have been cleaned up (removed before pushing). The learning curve on retest was a little sharp; I never found any good documentation, so most of this is stolen from the eunit retest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dave built retest for rebar integration tests, and there is no documentation besides the tests, but for whats it's worth it's very simple.
Thanks, in addition to the 0fea93c inline comments, please:
|
Addressed inline comments, adjusted commit message, improved comma consistency added copyright header, appended name to THANKS, then rebased. |
6c41a75
to
b98ad1b
Compare
%% | ||
%% rebar: Erlang Build Tools | ||
%% | ||
%% Copyright (c) 2014 Tuncer Ayaz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you mean Brian H. Ward
?
{ok, Output} = retest:sh("./rebar -v eunit"), | ||
io:format("output => ~p~n", [Output]), | ||
?assert(check_output(Output, "foo")), | ||
{ok,Listing} = file:list_dir(".eunit"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space after comma
Yes? |
Any thought on this? |
I have no way to test this, have no use for the feature personally, but if the code looks clean and it helps people, I see no reason not to introduce it apart from me not knowing what is 'expected correct behaviour' from this item. |
I don't know if there already exists a prior implementation in some cover utils package that might differ in output, but it's simple and seems to be useful for integration in systems that don't have an Erlang term reader. |
In an effort to incorporate output from cover into our automated build (CI) process, I created the ability to export the coverage information to a JSON file. This is done per-module, to simplify cross-application aggregation. added a new option
which should be using in conjunction with
{cover_enabled,true}.
to produce output file(s) of the form module_name.COVER.json
in the.eunit
directory.A retest suite is provided to illustrate the generation of the file(s).