This repository has been archived by the owner on May 12, 2018. It is now read-only.
Fixed version of #451 #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New vars for cross arch support: * REBAR_ARCH_TARGET * REBAR_TARGET_WORDSIZE * REBAR_ARCH_TARGET_VSN
New variable names: * REBAR_TARGET_ARCH * REBAR_TARGET_ARCH_VSN * REBAR_TARGET_ARCH_WORDSIZE
ghost
mentioned this pull request
Closed
| 16 -> "16"; | ||
| 32 -> "32"; | ||
| 64 -> "64"; | ||
| _ -> |
There was a problem hiding this comment.
why isn't this just:
case Wordsize of
"16" -> Wordsize;
"32" -> Wordsize;
"64" -> Wordsize;
_ -> ?WARN("REBAR_TARGET_ARCH_WORDSIZE bad value: ~p\n", [Wordsize]), "32"
endThere was a problem hiding this comment.
Nice catch, I don't know why @tonyrog checks if it's an integer. Thanks, simplified.
* fix commit messages * fix whitespace issues * move internal helper functions to correct location * unexport internal cross arch helper functions * fix 18.0 time API compatibility * fix Windows temp dir detection * use correct helper function name * use sh/2 instead of os:cmd/1 * match file:delete/1 result * use logging macros * fix typo * fix Dialyzer warnings * add Tony Rogvall to THANKS * add missing termination clause * os type must be win32, not windows * match file:write_file/2 result * document cross-arch variables * simplify env_wordsize/1 (Thanks Fred Hebert)
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixed version of #451: