Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Fix #536 #538

Merged
merged 1 commit into from Sep 12, 2015
Merged

Fix #536 #538

merged 1 commit into from Sep 12, 2015

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2015

No description provided.

@ferd
Copy link
Contributor

ferd commented Aug 24, 2015

Doesn't this also remove the flags from linux environments where it is available and could be relied on to build?

@ghost
Copy link
Author

ghost commented Aug 24, 2015

Yes, it does. This was introduced in 2.6.0 (6fca763):

Fix compiler invocation on multiarch Linux

This fixes port compilation for some configurations, notably this one:
Debian with 32-bit userspace, 64-bit kernel and 64-bit erlang packages.

Because the regex is too broad, it causes build errors. I don't know if we can fix it in the regex instead (and restore -m64 in LDFLAGS). What I do know is that 2.6.0 causes build errors with some toolchains.

/cc @liskin.

Slightly off-topic but related:
@ferd, I don't have access to OS X, but I wonder why #182 isn't an issue. I suppose the toolchain doesn't require extending it for newer versions anymore, as I doubt projects fix this in rebar.config for all OS X versions.

@ghost
Copy link
Author

ghost commented Sep 4, 2015

/cc @debalance @liskin

@ghost
Copy link
Author

ghost commented Sep 11, 2015

So, what do we do?

@liskin
Copy link
Contributor

liskin commented Sep 11, 2015

As I think I said elsewhere, I haven't used rebar (and Erlang) for months so I don't really care very much. If my changes cause trouble for people, I think it's fair that I just put those settings in my own rebar config.

@ghost
Copy link
Author

ghost commented Sep 12, 2015

@fred?

ferd added a commit that referenced this pull request Sep 12, 2015
@ferd ferd merged commit 894858d into rebar:master Sep 12, 2015
@ghost ghost deleted the fix-536 branch September 13, 2015 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants