This repository has been archived by the owner on May 12, 2018. It is now read-only.
Fix #544 #545
Merged
Fix #544 #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, commented in #544. |
A bunch of fixes:
* Only try to find out the user that is running the script if
that's necessary. That allows us to error out if we can't find
the user name.
* Fallback to 'whoami' in the unlikely case that 'id -un' does
not work.
* Use 'su' if 'sudo' is not installed, and if the user is 'root'.
(The 'sudo' binary is not installed by default in many OSs.)
|
You forgot to restore the SunOS ucb PATH extension. Other than that, I agree with the patch. Thanks again. |
|
The |
|
Doesn't the whoami fallback require the ucb path? |
|
Don't forget to append your name in THANKS. |
|
The |
|
+1 |
ferd
added a commit
that referenced
this pull request
Sep 27, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'whoami' is not POSIX-compliant, but 'id -un' is. This is true
at least since the 1003.1-2001 standard, I don't have a copy of the
previous 1003.2-1992 to verify it is true there too.
This causes problems in recent operating systems where 'whoami' is
not even shipped anymore.