Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Added report and verbose options for LFE compile. #546

Merged
merged 1 commit into from
Sep 27, 2015

Conversation

oubiwann
Copy link
Contributor

Recent builds of LFE have stopped reporting compile errors when compiled with rebar. Examination of this issue revealed that this was due to recent changes in default LFE compile options.

The way that LFE handles compile options has slightly changed; verbose and report are now provided as defaults only if no other options are passed; if other options are passed, these do not get set. As a result, we have stopped seeing compile error info when building with rebar.

This change brings back the previous level of reporting that LFE developers had when compiling their projects with rebar.

@ghost
Copy link

ghost commented Sep 26, 2015

Thanks. +1, once you've:

  1. appended your name in THANKS
  2. removed the trailing period in the commit message title/summary
  3. s/Added/Add/ in commit title/summary
  4. added the description as the commit message body

@oubiwann
Copy link
Contributor Author

Done!

Recent builds of LFE have stopped reporting compile errors when compiled with
rebar. Examination of this issue revealed that this was due to recent
changes in default LFE compile options.

The way that LFE handles compile options has slightly changed; ``verbose`` and
``report`` are now provided as defaults only if no other options are passed; if
other options are passed, these do not get set. As a result, we have stopped
seeing compile error info when building with rebar.

This change brings back the previous level of reporting that LFE developers had
when compiling their projects with rebar.
@rvirding
Copy link

This is actually very close to how the erlang compiler handles options, though it does allow prepending a single option to the default options which contain verbose. However giving a list of options completely replaces the default options.

@ghost
Copy link

ghost commented Sep 27, 2015

@ferd?

@oubiwann
Copy link
Contributor Author

@Tuncer I think that @rvirding was simply providing supplemental information, giving more details on the sensible way in which LFE handles its compile options ...

@rvirding
Copy link

Yes, I was just pointing out that the LFE compiler handles it's options
list in the same way the Erlang compiler does. The return values are now a
little different in details as the new compiler can handle files containing
multiple modules which can produce multiple beam files.

Robert
On 27 Sep 2015 3:16 pm, "Duncan McGreggor" notifications@github.com wrote:

@Tuncer https://github.com/tuncer I think that @rvirding
https://github.com/rvirding was simply providing supplemental
information, giving more details on the sensible way in which LFE handles
its compile options ...


Reply to this email directly or view it on GitHub
#546 (comment).

ferd added a commit that referenced this pull request Sep 27, 2015
Added report and verbose options for LFE compile.
@ferd ferd merged commit 79394fb into rebar:master Sep 27, 2015
@ghost
Copy link

ghost commented Sep 28, 2015

@oubiwann I've pinged @ferd so that he can merge (or reject). Sorry, I should have written that explicitly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants