Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Fix windows eunit tests #557

Merged
merged 1 commit into from
Oct 26, 2015
Merged

Conversation

lrascao
Copy link
Contributor

@lrascao lrascao commented Oct 24, 2015

File tests: windows file operations should abort on error
the same as unix operations invoked through sh. Also
windows does not support '?' characters in filenames.

Eunit tests: the 'All' prefix is missing on the 'x tests passed'
message. Eunit only prints the 'All' prefix if there are more
than 2 passed tests, dropping the prefix on the match works
for all cases.

@ferd
Copy link
Contributor

ferd commented Oct 24, 2015

That looks good, +1.

@ghost
Copy link

ghost commented Oct 24, 2015

  1. Why do we need rebar.bat in addition to the already generated rebar.cmd? Does it behave differently?
  2. Are you sure we weren't explicitly testing filenames with spaces? If you aren't, shouldn't we try to fix the incompatibility instead of removing the spaces?

Other than that, +1.

@lrascao
Copy link
Contributor Author

lrascao commented Oct 25, 2015

  1. right you are, no need for .bat whatsoever, didn't notice the .cmd being generated by bootstrap
  2. after further investigation, turns out the only thing that was causing the test to fail was the ?character which windows does not allow to be part of directory names, spaces are fine

File tests: windows file operations should abort on error
the same as unix operations invoked through sh. Also
windows does not support the '?' character in filenames.

Eunit tests: the 'All' prefix is missing on the 'x tests passed'
message. Eunit only prints the 'All' prefix if there are more
than 2 passed tests, dropping the prefix on the match works
for all cases.
@ghost
Copy link

ghost commented Oct 26, 2015

+1

ferd added a commit that referenced this pull request Oct 26, 2015
@ferd ferd merged commit 992dfac into rebar:master Oct 26, 2015
@lrascao lrascao deleted the fix/windows_eunit_tests branch October 31, 2015 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants