This repository has been archived by the owner on May 12, 2018. It is now read-only.
port_compiler: auto-select C++ specific link template #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though "$CC foo.o -lstdc++ -o foo.so" works if foo.o was built with $CXX, depending on the platform and toolchain and C++ standard used, it may not. In order to ensure this works reliably, we introduce EXE_LINK_CXX_TEMPLATE and DRV_LINK_CXX_TEMPLATE and auto-select if the port spec being built consists of at least one C++ source.
|
@laverite, can you verify this fixes dukesoferl/re2#15? |
ghost
mentioned this pull request
|
Alternatively, we could introduce |
|
@Tuncer thank you. yeah that fixes dukesoferl/re2#15 for me when I use rebar, but i'm using rebar3 :D. |
|
@lrascao, can you please review? |
|
@Tuncer looks good, merging |
Merged
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though "$CC foo.o -lstdc++ -o foo.so" works if foo.o was built with
$CXX, depending on the platform and toolchain and C++ standard used, it
may not. In order to ensure this works reliably, we introduce
EXE_LINK_CXX_TEMPLATE and DRV_LINK_CXX_TEMPLATE and auto-select if the
port spec being built consists of at least one C++ source.