Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cth_readable #1066

Merged
merged 1 commit into from
Feb 26, 2016
Merged

Bump cth_readable #1066

merged 1 commit into from
Feb 26, 2016

Conversation

ferd
Copy link
Collaborator

@ferd ferd commented Feb 19, 2016

The new version fixes parse transforms over OTP incompatibility that
would crash entire compile runs before.

Fixes #1063

@ferd
Copy link
Collaborator Author

ferd commented Feb 19, 2016

@soranoba If you want to try this branch, it should fix your problems.

@soranoba
Copy link
Contributor

Thank you for the fast response, but it has not yet been fixed =(

This bug is happen, because the parse_transform is success, but the attribute of optional_callbacks broken.

e.g.

a correct attribute when it doesn't run parse_transform

{optional_callbacks,[{b,0}]},

a broken attribute after it run parse_transform

{optional_callbacks,[{{atom,0,b},{integer,0,0}}]}

So, an exception does not occur during parse_transform.
(Sorry, I didn't understand that catch any error means using try~catch...)

@ferd
Copy link
Collaborator Author

ferd commented Feb 20, 2016

Then I don't think I can do much since I'm using an OTP library to do the parse transform.

@tsloughter
Copy link
Collaborator

Needs a rebase apparently.

The new version fixes parse transforms over OTP incompatibility that
would crash entire compile runs before.
@ferd
Copy link
Collaborator Author

ferd commented Feb 21, 2016

Done.

tsloughter added a commit that referenced this pull request Feb 26, 2016
@tsloughter tsloughter merged commit 5a36764 into erlang:master Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optional_callbacks is no longer available in beta-4
3 participants