Run all hooks #1091
Merged
Run all hooks #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsloughter
force-pushed
the
all_hooks
branch
2 times, most recently
from
d92f930
to
08c9ecb
Compare
tsloughter
force-pushed
the
all_hooks
branch
from
08c9ecb
to
3ad65d8
Compare
|
+1 on the change itself, tests would be good to avoid regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1089
Issue is that some providers, like
compileandclean, distinguish between top level hooks and per-app hooks. in order to keep them from running twice we remove the hooks from the top level State if it is a single top level app in the project (the hook stays with the app). But in the case ofeunitandctandrelxthese per-app hooks are not run. To fix this I have it now run all hooks for those providers. I think that is the proper fix but open to alternatives.