Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cover_spec options for ct #769

Merged
merged 1 commit into from
Sep 6, 2015
Merged

Conversation

surik
Copy link
Contributor

@surik surik commented Sep 2, 2015

There is only cover option but rebar_prv_common_test.erl uses cover_spec

@ferd
Copy link
Collaborator

ferd commented Sep 2, 2015

@talentdeficit ?

@talentdeficit
Copy link
Contributor

i prefer to leave it as is so rebar3 ct --cover and rebar3 eunit --cover do the same thing but i guess we could always rename both

@ferd
Copy link
Collaborator

ferd commented Sep 2, 2015

I'd rather stick with --cover personally and normalize on that.

@surik
Copy link
Contributor Author

surik commented Sep 3, 2015

If we leave it as is how do we specify cover.spec files? ct:run_tests/1 doesn't have options cover_spec. This PR is not about CLI option --cover/-c it is about cover option for ct

I think we can do it little easier via transform_opts/2, I will rework it.

@surik
Copy link
Contributor Author

surik commented Sep 3, 2015

Done

@talentdeficit
Copy link
Contributor

+1, this looks fine to me

ferd added a commit that referenced this pull request Sep 6, 2015
@ferd ferd merged commit 768889a into erlang:master Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants