Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add current_app attribute for setting before calling hooks #777

Merged
merged 1 commit into from
Sep 6, 2015

Conversation

tsloughter
Copy link
Collaborator

No description provided.

@ferd
Copy link
Collaborator

ferd commented Sep 5, 2015

What is this for?

@tsloughter
Copy link
Collaborator Author

@ferd for hooks. I'll be adding docs to the plugins page when this is added. Basically it allows a compile hook to not having to figure out what application it is being run on, it is given as part of the state. This will simplify getting the app_info record for finding opts for the plugin.

@tsloughter
Copy link
Collaborator Author

Also, will allow (in another PR) to possibly make @Licenser happy. I was thinking the returned State's current_app could become the new app_info record for the application being built. Thus allowing hooks to update the build opts of an app without touching the State.

ferd added a commit that referenced this pull request Sep 6, 2015
add current_app attribute for setting before calling hooks
@ferd ferd merged commit a81357b into erlang:master Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants