Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks/artifacts are always run/resolved from an app unless at top of umbrella #779

Merged
merged 1 commit into from
Sep 6, 2015

Conversation

tsloughter
Copy link
Collaborator

All hooks will be run as part of the app_info set of hooks, in compile for example: https://github.com/rebar/rebar3/blob/master/src/rebar_prv_compile.erl#L87 and artifacts will be found relative to an app's output directory, except in the case of being defined in the rebar.config at the top level of an umbrella project. In that case artifacts will be resolved from profile_dir (eg _build/default/) and hooks will be run from the top level before any part of a provider is run, like https://github.com/rebar/rebar3/blob/master/src/rebar_prv_compile.erl#L49

Additionally 3 variable can be used in the artifacts string: base_dir, profile_dir or out_dir -- out_dir is the default path to start finding artifacts but I figured it would be nice to let it be explicit as well, example: {artifacts, ["{{out_dir}}/priv/eleveldb.so"]}.

ferd added a commit that referenced this pull request Sep 6, 2015
hooks/artifacts are always run/resolved from an app unless at top of umbrella
@ferd ferd merged commit e1cba5a into erlang:master Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants