-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plt_include_all_deps dialyzer option #783
Conversation
Seen1 = sets:add_element(App, Seen), | ||
case code:lib_dir(App) of | ||
{error, _} -> | ||
Seen1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should error if an app doesn't exist. The application can't be started if a dependency does not exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right.
I will fix these error handlings.
I fixed the code. |
@fishcakez @ferd is this good to merge now? |
👍 from me. |
Add plt_include_all_deps dialyzer option
merged and updated the docs: http://www.rebar3.org/v3.0/docs/configuration#dialyzer -- this needs to be made friendlier but oh well. |
Thank you! |
According to #778, I tried to add
plt_include_all_deps
dialyzer option.If the value is
true
, dialyzer will include not only the first level dependencies but also all nested dependent applications in the PLT file.