Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plt_include_all_deps dialyzer option #783

Merged
merged 7 commits into from
Sep 15, 2015

Conversation

sile
Copy link
Contributor

@sile sile commented Sep 7, 2015

According to #778, I tried to add plt_include_all_deps dialyzer option.

%% in rebar.config
{dialyzer, [
    {plt_include_all_deps, true}
]}.

If the value is true, dialyzer will include not only the first level dependencies but also all nested dependent applications in the PLT file.

Seen1 = sets:add_element(App, Seen),
case code:lib_dir(App) of
{error, _} ->
Seen1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should error if an app doesn't exist. The application can't be started if a dependency does not exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.
I will fix these error handlings.

@sile
Copy link
Contributor Author

sile commented Sep 12, 2015

I fixed the code.
Please take another look.

@tsloughter
Copy link
Collaborator

@fishcakez @ferd is this good to merge now?

@fishcakez
Copy link
Contributor

👍 from me.

ferd added a commit that referenced this pull request Sep 15, 2015
Add plt_include_all_deps dialyzer option
@ferd ferd merged commit 493d290 into erlang:master Sep 15, 2015
@ferd
Copy link
Collaborator

ferd commented Sep 15, 2015

merged and updated the docs: http://www.rebar3.org/v3.0/docs/configuration#dialyzer -- this needs to be made friendlier but oh well.

@sile
Copy link
Contributor Author

sile commented Sep 15, 2015

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants