Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of version #'s of dependencies #813

Merged
merged 1 commit into from
Sep 18, 2015
Merged

Conversation

jbalint
Copy link
Contributor

@jbalint jbalint commented Sep 18, 2015

Version #'s with patch info like "1.1.1-x" would cause an error. Now
tokenize the version string with "." AND "-".

Some versions of OTP return an unexpected version #:

8> application:get_key(ssl, vsn).
{ok,"6.0.1-basho1"}

This was causing a bootstrap error:

./bootstrap
===> Updating package registry...
===> Writing registry to /home/jbalint/.cache/rebar3/hex/default/registry
===> Generating package index...
===> Writing index to /home/jbalint/.cache/rebar3/hex/default/packages.idx
===> Verifying dependencies...
===> Fetching bbmustache ({pkg,<<"bbmustache">>,<<"1.0.4">>})
escript: exception error: no match of right hand side value
                 {error,
                     {rebar_fetch,
                         {fetch_fail,{pkg,<<"bbmustache">>,<<"1.0.4">>}}}}

Version #'s with patch info like "1.1.1-x" would cause an error. Now
tokenize the version string with "." AND "-".
@tsloughter
Copy link
Collaborator

Thanks!

tsloughter added a commit that referenced this pull request Sep 18, 2015
Fix parsing of version #'s of dependencies
@tsloughter tsloughter merged commit 1d842d5 into erlang:master Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants