Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettify all of common test output. #917

Merged
merged 4 commits into from
Nov 13, 2015
Merged

Prettify all of common test output. #917

merged 4 commits into from
Nov 13, 2015

Conversation

ferd
Copy link
Collaborator

@ferd ferd commented Nov 13, 2015

This uses cth_readable to:

  • silence error_logger output to the shell unless a test fails
  • silence ct:pal output to the shell unless a test fails

I have currently not baked in any way to disable this behaviour, but I
figured if it is required, there is time to do it before the final
3.0.0 release.

What it looks like

example
example

This uses cth_readable to:
- silence error_logger output to the shell unless a test fails
- silence ct:pal output to the shell unless a test fails

I have currently not baked in any way to disable this behaviour, but I
figured if it is required, there is time to do it before the final
3.0.0 release.
@tsloughter
Copy link
Collaborator

Cool, +1 if I read this correctly and you do plan to add a way to switch it off before we go 3.0.0.

@ferd
Copy link
Collaborator Author

ferd commented Nov 13, 2015

Yeah. It's just that I want us to cut the last beta soon and get this through for it. I have a few shell bugs to tackle in the upcoming days too.

@ferd
Copy link
Collaborator Author

ferd commented Nov 13, 2015

That being said, what format should the switch take? {ct_prettify, false}, {ct_readable, false} or something else?

@tsloughter
Copy link
Collaborator

Yea, probably {ct_readable, false} so it is nearly the same name as the app.

I'd also like to include eunit formatters. I can quickly add that and make a PR if you agree that would be good to include in a similar fashion to this.

@ferd
Copy link
Collaborator Author

ferd commented Nov 13, 2015

Yeah that could be good to have too.

@tsloughter
Copy link
Collaborator

Should add the app to rebar.app.src applications

@ferd
Copy link
Collaborator Author

ferd commented Nov 13, 2015

@tsloughter done with the switch
@talentdeficit interested in your review of this.

@talentdeficit
Copy link
Contributor

+1

i like the idiom you used for ensuring things were only present in a list once, i'll have to remember that

@ferd
Copy link
Collaborator Author

ferd commented Nov 13, 2015

Well if the entry was there twice, it will be there twice again. It actually ensures they are there once or as many times as they were before. But yeah, it's nifty.

ferd added a commit that referenced this pull request Nov 13, 2015
Prettify all of common test output.
@ferd ferd merged commit 0b01c9f into erlang:master Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants