Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support temporary cdn change with HEX_CDN os var #923

Merged
merged 1 commit into from
Dec 19, 2015

Conversation

tsloughter
Copy link
Collaborator

No description provided.

@@ -193,7 +193,7 @@ mock_config(Name, Config) ->
meck:expect(rebar_dir, global_cache_dir, fun(_) -> CacheRoot end),

meck:new(rebar_packages, [passthrough]),
meck:expect(rebar_packages, registry_dir, fun(_) -> CacheDir end),
meck:expect(rebar_packages, registry_dir, fun(_) -> {ok, CacheDir} end),
meck:expect(rebar_packages, package_dir, fun(_) -> CacheDir end),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems inconsistent registry_dir returns {ok, Dir} or {error, Reason} whereas package_dir returns CacheDir or crashes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, updating.

@ferd
Copy link
Collaborator

ferd commented Dec 19, 2015

+1, merge when tests pass.

ferd added a commit that referenced this pull request Dec 19, 2015
support temporary cdn change with HEX_CDN os var
@ferd ferd merged commit fe470e5 into erlang:master Dec 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants