Default to no eunit formatter if verbose specified #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you rebase this, I'll merge it after you do. |
The previous default meant that verbose output would not be emitted.
tokenrove
force-pushed
the
fix-eunit-verbose
branch
from
b069bbb
to
6140ef6
Compare
|
Should be good to go. Let me know if there's anything else. |
tsloughter
added a commit
that referenced
this pull request
Dec 1, 2015
Default to no eunit formatter if verbose specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous default meant that verbose output would not be emitted, thanks to the custom formatter which doesn't seem to interact well with
verbose.I'm opening this now because I wanted to quickly fix this behavior, but I'm open to suggestions on how to improve the tests for this.