Missing parent table in SelectFields for UnionType and InterfaceType

[illambo]

Versions:

• graphql-laravel Version: 8.5.0
• Laravel Version: 9.48.0
• PHP Version: 8.1.14

Description:

graphql-laravel/src/Support/SelectFields.php

Line 257 in fc0d1d5

$select = ['*'];

Hi, it seems missing to specify the parent table, otherwise it can cause problems with joins (I have a local project on which I had the problem but I can not share more data at the moment).

Better use:
$select = [$parentTable . '.*'];

What do you think?

[mfn]

🤷🏼

SelectFields is a bane, I've no idea. Did you try it? Write a test with your situation, change the code, all tests still green?

[illambo]

Ok, as soon as I can I elaborate tests and pr.

[illambo]

I'm sorry, I only realized now that nothing has been done about it. I'm going to close the issue for now and if necessary I'll reopen it with a complete example. Thank you