Add MRU sort settings #36

reblws · Dec 2, 2017 · e82725b · e82725b
1 parent b41f7d7
commit e82725b
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/src/core/pages/settings/input-bindings.js b/src/core/pages/settings/input-bindings.js
@@ -13,6 +13,7 @@ const d = document;
 const disableBindings = {
   showRecentlyClosed: ['recentlyClosedLimit', 'alwaysShowRecentlyClosedAtTheBottom'],
   enableFuzzySearch: ['threshold', 'shouldSort'],
+  shouldSortByMostRecentlyUsedOnPopup: ['shouldSortByMostRecentlyUsedAll'],
 };
 const mirrorBindings = {
   threshold: 'thresholdDisplay',
@@ -31,11 +32,11 @@ export default function addInputBindings() {
       const dependents = disableBindings[masterId];
       dependents.forEach((dependentId) => {
         const dependent = d.getElementById(dependentId);
-        // Don't need strict compare
-        // eslint-disable-next-line eqeqeq
         dependent.disabled = !checked;
         const label = d.querySelector(`label[for=${dependentId}]`);
         if (!checked) {
+          dependent.checked = false;
+          dependent.dispatchEvent(new Event('change'));
           label.classList.add('disabled-label');
         } else {
           label.classList.remove('disabled-label');

diff --git a/src/core/reducers/defaults.js b/src/core/reducers/defaults.js
@@ -16,6 +16,8 @@ export const initialGeneralSettings = {
   recentlyClosedLimit: 5,
   useFallbackFont: false,
   showLastQueryOnPopup: false,
+  shouldSortByMostRecentlyUsedOnPopup: false,
+  shouldSortByMostRecentlyUsedAll: false,
 };
 
 export const initialState = {

diff --git a/src/static/settings/index.html b/src/static/settings/index.html
@@ -199,6 +199,18 @@ <h2>Search Results</h2>
             Show the last query's results when opening the popup window
           </label>
         </p>
+        <p class="inputs">
+          <input type="checkbox" name="shouldSortByMostRecentlyUsedOnPopup" id="shouldSortByMostRecentlyUsedOnPopup">
+          <label for="shouldSortByMostRecentlyUsedOnPopup">
+           Sort tabs by most recently used (MRU) on popup
+          </label>
+        </p>
+        <p class="inputs">
+<input type="checkbox" name="shouldSortByMostRecentlyUsedAll" id="shouldSortByMostRecentlyUsedAll">
+<label for="shouldSortByMostRecentlyUsedAll">
+            <em>Always</em> sort tabs by most recently used (MRU)
+          </label>
+        </p>
       </fieldset>
       <fieldset>
         <legend>