-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve keyboard navigation #56
Comments
Hey @drtebi, thanks for your feedback, I've implemented most of your suggestions. The only one I'm not sure about is one aspect of the Home/End changes. Right now the way I have it set up is if either of those keys are pressed, the focus jumps to the end of the tab list regardless of whether the search input is active or not, but Home/End keys are also used to jump to the end of a line. If the search input is active I'm thinking maybe it shouldn't skip to the end of the tablist, but should jump the cursor to the end of the search input instead. Curious to hear your thoughts on this. |
Closes #55, #56 - Changed previous tab command behavior: When the search input is active, going to the previous tab selects the last tab instead - Improved key-handling for common system shortcuts: + <kbd>Shift</kbd>-<kbd>Tab</kbd> now goes to the previous item in the tab list + <kbd>Home</kbd> and <kbd>End</kbd> jump to the beginning or the ending of the tab list + <kbd>PgUp</kbd> and <kbd>PgDown</kbd> go to the previous or next tab in the tab list
Hi, you are completely right, if the focus is on the search box, then Home and End should work with the text (e.g. move the cursor within the text box accordingly). If focus is on the list, then Home and End would be nice to work as a "jump" to the top and bottom of the list. Basically... it should be easy and quick to use the plugin without a mouse... :) |
+1 for "no mouse" |
Thanks, I should have made it like that from the start. I'm having some issues with my PC at the moment. I'll push this change as soon as the issues are resolved. Did this break for you recently? If not, this sounds like #13 and will be fixed in a near-future Firefox update. |
Nope, it is the first time I've installed the extension |
Ah ok @ciufudean, it should be fixed by Firefox 60. In the meantime, try pressing Tab as soon as you open the popup window. That should focus the search input immediately. |
pressing Tab twice will do the trick ;), once for the popup window, once for the input |
This is a very nice add-on, I just wish a couple of keyboard actions could be improved:
These are just my improvement suggestions. The add-on itself is already very good, a bit of polishing of the keyboard navigation would make it perfect :)
The text was updated successfully, but these errors were encountered: