Missing effects behind textboxes

[Surihix]

I am making this a new separate issue with this bug, as I had already mentioned this in the missing star effect issue posted by another person to make it easier to find by others.

There is an effect behind every text box where all of tht is either out of focus and is completely missing at higher than 720p and 1080p resolutions. Here are the screenshots at different resolutions.

this set of screenshot r taken when the game ran at 1280x1024 resolution with the effect in place. Notice tht globe like effect and the spinning gears effect in the boxes.
https://imgur.com/o2HVhbo
https://imgur.com/Jn9VQwr
https://imgur.com/VTUccWm
https://imgur.com/yzKANCX

this set of screenshot r taken when the game ran at 1366x768 resolution with the effect slightly misaligned.
https://imgur.com/0yQW8Sl
https://imgur.com/JEoflCX
https://imgur.com/xLZ4Se0
https://imgur.com/vGm39oo

this set of screenshots r taken when the game ran at 1920x1080 resolution with the effect missing.
https://imgur.com/cFg02DX
https://imgur.com/LkBTwlp
https://imgur.com/Ikei5sh
https://imgur.com/Um6c4tX

I am really hoping you can solve these issues with an update of sorts to the fix and also this issue is not present in the new Xbox one port of the game as the game seems to scale with all the UI elements properly.

[rebtd7]

Fixed in 1.4.5 (hopefully without breaking anything else).

[devXin]

It seems the fix for this slightly breaks the inventory and datalog menus (the item and entry lists are indented and cut off), at least at 1920x1200 (didn't have a chance to check other resolutions). It does restore the missing UI animations.

[rebtd7]

Thanks devXin.

It seems to only happen on non-16:9 resolutions, which is why I did not catch it when I tested.

I've removed the release for now so people won't grab the bugged release, but I'm attaching it here if anyone else wants to test it too.

Hopefully fixing this won't be too time consuming...

link removed

[Nucleoprotein]

Maybe better idea is to detour IDirect3DDevice9::SetScissorRect and change size there?
You need only to identify correct RECT by something ...

EDIT: RECT is static data? so pointer will be always the same? is this is the case this is easy to identify then.
EDIT2: Why MainContext::ScaleScissorRect is not used? maybe this is issue, seems you set scaling to none by NOPing
EDIT3 if you want to use it in hkIDirect3DDevice9::SetScissorRect you can easily remove const by something like:
context.ScaleScissorRect(const_cast<RECT*>(pRect));

[rebtd7]

@Nucleoprotein
I'm having issues with git in my machine so I uploaded the changes using the web interface and I forgot to upload the IDirect3DDevice9.cpp. Oops. I was confused by your comment until I realized that.

The game uses the stack for most of its RECT, so this debugging and figuring out how it is being set is painful.

The scale is only 1.0f at start (this is for compatibility with anything different from FF13, like FF13-2).
The startup routine for FF13 sets this to different values.

I've uploaded a new release fixing the issues, please report if there's still anything broken.

[Nucleoprotein]

@rebtd7
Thanks for explanation, code looks correct now.

[Surihix]

Just tested with the latest experimental fix and seems like everything is working fine. All the effects r rendering perfectly in the text boxes. I even went the extra mile checking whether those cool shop loading animations r effected negatively and they all play fine. I am assuming they r FMV videos with all those animations pre rendered.
I am running the game on a DSR resolution of 4K on my 1080p 16:9 monitor and yeah the effects r scaled properly with the downscaling feature as well.

Huge thnx for the fix and with this I can happily conclude tht all graphical bugs related to scaling is fixed in this game and it can be considered almost on par to the new Xbox one port when it comes to no scaling related bugs.
I had also made two guides on steam detailing every issues and fixes that can be used to solve them and will update with this new fix there. the second game also runs fine without any issues in the new fix. so yeah only one bug remains in the second game due to higher framerate with the chocobo racing and I hope tht too will get fixed eventually.

[rebtd7]

@Surihix I saw your guides, thanks for doing them and for testing the fix.