Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "no results" card in businesses only when api returns empty array and not on initial page load. #247

Closed
Mhmdabed11 opened this issue Jun 12, 2020 · 2 comments
Projects

Comments

@Mhmdabed11
Copy link
Contributor

In the /businesses page, the no results card is shown on page load for a small amount of time then the results cards are displayed. On the initial load, maybe a skeleton loader should exist while making the api call to get the search results.

@Mhmdabed11 Mhmdabed11 changed the title Show no results card in businesses only when api returns empty array and not on initial page load. Show "no results" card in businesses only when api returns empty array and not on initial page load. Jun 12, 2020
@magnificode magnificode added this to To do in RBB Website Jun 19, 2020
@M0nica
Copy link
Contributor

M0nica commented Jun 20, 2020

It looks to me like this was resolved? On initial load of /businesses I no longer see the no results card before results load.

@magnificode
Copy link
Member

@M0nica This has indeed been resolved in our switch to our custom API in #263. Appreciate you bringing this to our attention @Mhmdabed11!

RBB Website automation moved this from To do to Done Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
RBB Website
  
Done
Development

No branches or pull requests

3 participants