Change over from Algolia search to PHP search backend #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We originally added in Algolia as a stop gap as we had not very many days before launch and needed to get something in quickly. However Algolia is very expensive and although the searching is great we cannot afford to keep running the site on it. Here is where @ChrisHolland came in :D. There is now a PHP backend setup that is super fast and works the same as Algolia for all intents and purposes for our search! The new useSearch hook uses that and removes the need for Algolia entirely from the site.
llexical
requested review from
domitriusclark,
magnificode and
racedale
as code owners
magnificode
requested changes
Jun 21, 2020
There was a problem hiding this comment.
This looks awesome @llexical thank you so much for getting this taken care of!! Appreciate you keeping the documentation updated as well 😄
Left one small comment about being able to remove any of the Algolia NPM packages.
From a code standpoint everything looks excellent. I need to get the SEARCH_API_ENDPOINT value set in Netlify so that I can do some testing for ya.
Thank you so much again!
|
Oh! @llexical any chance we can also remove the "Search powered by Algolia" bit in this PR as well? |
magnificode
reviewed
Jun 21, 2020
llexical
commented
Jun 21, 2020
Prefixed the frontend search environment variable with Gatsby. Honestly not sure how much of a difference it makes however it does make it clear and it guarentees it will build correctly so added it in. Uninstalled the Algolia library and removed the 'search powered by Algolia' message.
After the move over from Algolia to our own inhouse search the website and donate links were not hooked up correctly with the cards.
magnificode
approved these changes
Jun 22, 2020
racedale
deleted the
feature/237-changeover-from-algolia-to-new-search-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally added in Algolia as a stop gap as we had not very many
days before launch and needed to get something in quickly. However
Algolia is very expensive and although the searching is great we cannot
afford to keep running the site on it.
Here is where @ChrisHolland came in :D. There is now a PHP backend
setup that is super fast and works the same as Algolia for all intents
and purposes for our search! The new useSearch hook uses that and
removes the need for Algolia entirely from the site.
NOTE: I believe the new backend only indexes approved Businesses, so I could remove that search filter.
Pages/Interfaces that will change
Steps to test
Additional Notes
SEARCH_API_ENDPOINTenvironment variable to Netlify.