Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for .NET 5 #20

Merged
merged 1 commit into from
Dec 1, 2020
Merged

add support for .NET 5 #20

merged 1 commit into from
Dec 1, 2020

Conversation

mastersign
Copy link
Contributor

  • Add net5.0 to the TFMs
  • Introduce conditional dependency references
    • For .NET Framework 4 use Npgsql 4.1.6 and include reference to System.Transactions
    • For .NET Standard 2 and .NET 5 use Npgsql 5.0.0

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2020

CLA assistant check
All committers have signed the CLA.

@mastersign
Copy link
Contributor Author

mastersign commented Nov 26, 2020

It looks to me in the test log of appveyor, that the tests are only run against .NET Framework 4. If I run dotnet test locally (with the .NET 5.0 SDK CLI) it picks up on all three TFMs of the test project .NET Framework 4, .NET Core 3.1 and .NET 5.0 and all tests succeeded. But in appveyor the autmatically generated test command seems to run only the first TFM.

@mookid8000 mookid8000 merged commit 534e6a0 into rebus-org:master Dec 1, 2020
@mookid8000
Copy link
Member

Excellent, thanks! 🙂 it's out as Rebus.PostgreSql 7.2.0 on NuGet.org in a few minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants