Better performance on publisher confirms in transaction #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Jan 29, 2019
|
Perfect! Great work, thanks 👍 |
|
it'll be out in Rebus.RabbitMq 5.0.1 in a few minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending multiple messages in a rebus transaction, it takes a lot of time to confirm each message individually. Since we are reusing the same IModel from the current transaction, it should be safe to confirm all messages in one go. The performance difference when running inside a rebus transaction is huge.
Batch confirms is also recommended from the RabbitMQ webside due to performance and latency.
I extended the current performance tests to also run in transaction to be able to compare side by side.
Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.