Disabling Remediation Configuration before deleting config rule #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Muhammad-Ahmad-Rai, thanks for the PR and sorry for the late reply! Could you resolve the conflict and rebase your changes, ideally without the changes from #993? That would be awesome 🙂 |
der-eismann
added
the
status/waiting-reponse
Muhammad-Ahmad-Rai
force-pushed
the
main
branch
3 times, most recently
from
64b19e1
to
ef0c468
Compare
@der-eismann Done |
…ttempting deletion of rule
Muhammad-Ahmad-Rai
force-pushed
the
main
branch
from
ef0c468
to
419f8ed
Compare
der-eismann
reviewed
Aug 25, 2023
Comment on lines
+47
to
+49
| f.svc.DeleteRemediationConfiguration(&configservice.DeleteRemediationConfigurationInput{ | ||
| ConfigRuleName: f.configRuleName, | ||
| }) |
There was a problem hiding this comment.
Suggested change
| f.svc.DeleteRemediationConfiguration(&configservice.DeleteRemediationConfigurationInput{ | |
| ConfigRuleName: f.configRuleName, | |
| }) | |
| _, err := f.svc.DeleteRemediationConfiguration(&configservice.DeleteRemediationConfigurationInput{ | |
| ConfigRuleName: f.configRuleName, | |
| }) | |
| if err != nil { | |
| return err | |
| } |
I think we should catch the error here
There was a problem hiding this comment.
There is a chance that no remediation configuration exist for the given config rule, and that will result in NoSuchRemediationConfigurationException
der-eismann
removed
the
status/waiting-reponse
der-eismann
approved these changes
Aug 25, 2023
svenwltr
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the Error:
"ResourceInUseException: The rule{RULE_NAME} currently has a RemediationConfiguration. Please delete the RemediationConfiguration and try again."