Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safer.writer does not correctly wrap existing streams #23

Closed
rec opened this issue May 1, 2023 · 3 comments
Closed

safer.writer does not correctly wrap existing streams #23

rec opened this issue May 1, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@rec
Copy link
Owner

rec commented May 1, 2023

See unit test.

This is a serious bug that needs immediate fixing!

@rec rec added the bug Something isn't working label May 1, 2023
@rec rec self-assigned this May 1, 2023
rec added a commit that referenced this issue May 1, 2023
@rec
Copy link
Owner Author

rec commented May 2, 2023

The issue so far is that the underlying stream is not closed so the data is not written, but simply closing it breaks everything else. :-D

Still, I'm closer to a solution.

rec added a commit that referenced this issue May 2, 2023
rec added a commit that referenced this issue May 2, 2023
@rec
Copy link
Owner Author

rec commented May 2, 2023

Only one case left to fix, which seems to be a separate error!

rec added a commit that referenced this issue May 2, 2023
@rec
Copy link
Owner Author

rec commented May 2, 2023

Could not resolve that last case - writing to a temp file. No one has hit it yet including me. Now in this one case I raise a NotImplementedException.

I see how to code it, but I'm out of time!

@rec rec closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant