Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can you please make the DetourCommon methods all public? #121

Closed
SetoKaiba opened this issue Mar 27, 2022 · 2 comments
Closed

Can you please make the DetourCommon methods all public? #121

SetoKaiba opened this issue Mar 27, 2022 · 2 comments

Comments

@SetoKaiba
Copy link

Can you please make the DetourCommon methods all public?
The methods are util methods. It should be useful everwhere.
@ppiastucki
Copy link
Collaborator

Let me know exactly which methods you want to be made public.
The fewer methods are public the better to limit the burden related to keeping the library backward-compatible.

@SetoKaiba
Copy link
Author

I see. vDist and vEqual are the two methods now I call them by reflection.

ppiastucki added a commit that referenced this issue Apr 16, 2022
@ppiastucki
Make vDist and vEqual public (closes #121)
94249d3
ppiastucki added a commit that referenced this issue Apr 16, 2022
@ppiastucki
Make vDist and vEqual public (closes #121)
c5e733d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SetoKaiba @ppiastucki