You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I was reading a lot of the library, because I ported it to use JOML instead of float[3]s.
I discovered multiple places like
if(a < b) return -1;
else if(a > b) return +1;
return 0;
This could be simplified with Integer.compare(a,b) or Float.compare(a,b) (depending on the type).
The bug I discovered is that in RecastContour.getCornerHeight() a boolean is passed, that probably originally was a reference. In Java, it just gets passed, and never set to true. (IntelliSense told me)
The text was updated successfully, but these errors were encountered:
Hi, I was reading a lot of the library, because I ported it to use JOML instead of float[3]s.
I discovered multiple places like
This could be simplified with Integer.compare(a,b) or Float.compare(a,b) (depending on the type).
The bug I discovered is that in RecastContour.getCornerHeight() a boolean is passed, that probably originally was a reference. In Java, it just gets passed, and never set to true. (IntelliSense told me)
The text was updated successfully, but these errors were encountered: