Add support for AABB shaped obstacles to dtTileCache #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice and simple. This looks good. 👍 |
| return DT_SUCCESS; | ||
| } | ||
|
|
||
| dtStatus dtTileCache::addObstacle(const float* bmin, const float* bmax, dtObstacleRef* result) |
There was a problem hiding this comment.
Maybe we can call this something else? I'm not a fan of an overload where the function does something semantically different (well I know, it adds an obstacle, but I mean a box vs a cylinder). Maybe something like addBoxObstacle instead?
|
I agree, looks good aside from the naming thing I've commented on. |
|
Agreed. After the naming change we can merge this. Thanks! 👍 |
|
Changed name as per comments |
|
Thank you, LGTM now. As a last thing, can you fix your Git settings so the commit is properly linked to your Github account? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current dtTileCache supports cylindrical shaped obstacles, but this tends to be a very limiting obstacle shape that doesn't fit many use cases very well. An AABB is a bit more flexible and doesn't take much to implement.
It would be nice to also support extruded convex polys like recast does, but this is a good start.