chore(cmake): fix for cmake recast-demo build - add libraries #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the original issue? Could you post the build log? FYI there is working CI job building RecastDemo on Ubuntu. So likely there is an issue unrelated to the CMake config in this repository. |
elsid
reviewed
May 27, 2024
Comment on lines
+37
to
+50
| file(GLOB DEBUG_UTILS_SRC "${CMAKE_CURRENT_SOURCE_DIR}/../DebugUtils/Source/*.cpp") | ||
| add_library(DebugUtils SHARED ${DEBUG_UTILS_SRC}) | ||
|
|
||
| file(GLOB RECAST_SRC "${CMAKE_CURRENT_SOURCE_DIR}/../Recast/Source/*.cpp") | ||
| add_library(Recast SHARED ${RECAST_SRC}) | ||
|
|
||
| file(GLOB RECAST_DETOUR_SRC "${CMAKE_CURRENT_SOURCE_DIR}/../Detour/Source/*.cpp") | ||
| add_library(Detour SHARED ${RECAST_DETOUR_SRC}) | ||
|
|
||
| file(GLOB RECAST_DETOUR_CROWD_SRC "${CMAKE_CURRENT_SOURCE_DIR}/../DetourCrowd/Source/*.cpp") | ||
| add_library(DetourCrowd SHARED ${RECAST_DETOUR_CROWD_SRC}) | ||
|
|
||
| file(GLOB RECAST_DETOUR_TILE_CACHE_SRC "${CMAKE_CURRENT_SOURCE_DIR}/../DetourTileCache/Source/*.cpp") | ||
| add_library(DetourTileCache SHARED ${RECAST_DETOUR_TILE_CACHE_SRC}) |
There was a problem hiding this comment.
This adds duplicated definitions for libraries built in other places:
This is not what should be done here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake was not building the recast-demo because it could not link the libraries
The following libraries have been added: DebugUtils, Recast, Detour, DetourCrowd, DetourTileCache
This has only been tested on Ubuntu.