Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS pre-processing #17

Open
mike42 opened this issue May 21, 2017 · 1 comment
Open

CSS pre-processing #17

mike42 opened this issue May 21, 2017 · 1 comment

Comments

@mike42
Copy link
Contributor

mike42 commented May 21, 2017

We currently use a static CSS file, but this has two main problems-

  • Repetition: We will soon generate more height/width scaling classes, which is hard to maintain manually, but can be done easily with a few loops in Sass or similar.
  • Vendor prefixes: Output via wkhtmltopdf did not work as expected due to the lack of -webkit-* vendor tags for scaling. This can also be added via a pre-processor.
@mike42
Copy link
Contributor Author

mike42 commented May 26, 2017

Example of issue below- correctly-rendered receipt in any modern browser, while wkhtmltopdf does not pick up the height/width multiples-

screenshot from 2017-05-26 23-45-28

We need to support this as a target so that we don't need to touch PDF support ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant