jshint & eslint

.dockerignore

@@ -0,0 +1,11 @@
+.git
+node_modules
+#config/runtime.json
+config/runtimes.json
+functionalTest
+test
+coverage
+*.iml
+*.ipr
+*.iws
+.idea

.eslintrc

@@ -114,7 +114,6 @@
     "key-spacing": [ 0 ],
     "new-cap": [ 0 ],
     "no-lonely-if": [ 0 ],
-    "no-multi-str": [ 0 ],
     "no-underscore-dangle": [ 0 ],
     "quotes": [ 0 ],
     "semi": [ 0 ],

.jshintignore

@@ -0,0 +1,8 @@
+# node_modules ignored by default
+node_modules/
+
+# other ignored directories
+coverage/
+test/
+functionalTest
+public

.jshintrc

@@ -3,7 +3,7 @@
   "bitwise":    false,
   "asi":        false,
   "browser":    false,
-  "camelcase":  false,
+  "camelcase":  true,
   "curly":      true,
   "devel":      false,
   "enforceall": true,
@@ -33,5 +33,6 @@
   "undef":      true,
   "unused":     true,
   "maxlen":     140,
-  "latedef":    true
+  "latedef":    true,
+  "globals": { "JSON": true }
 }

index.js

@@ -1,5 +1,6 @@
+'use strict';
+
 var meta = require('./lib/meta');
-var logger = require('./lib/logger/logger').logger;
 var ticketsClient = require('./lib/client/createTicket');
 var updateTicketClient = require('./lib/client/updateTicket');
 var getTicketClient = require('./lib/client/getTicket');

lib/client/account.js

@@ -52,7 +52,7 @@ var getTicketsRequest = function getTicketsRequest(jar, month, page, formConfig,
   };
 
   try {
-    request(opt, function (error, response, body) {
+    return request(opt, function (error, response, body) {
 
       if (error) {
         logger.info('error on getTicketsRequest: ', error);
@@ -137,7 +137,7 @@ var handleReceiptsForMonth = function handleReceiptsForMonth(jar, month, formCon
   var collection = [];
   var page = 0;
 
-  async.forever(
+  return async.forever(
     function (cb) {
       page++;
       buildList(jar, month, page, formConfig, function (err, list) {
@@ -164,7 +164,7 @@ var handleReceiptsForMonth = function handleReceiptsForMonth(jar, month, formCon
 var handleReceipts = function handleReceipts(jar, formConfig, callback) {
   logger.debug('handleReceipts');
 
-  async.map(
+  return async.map(
     MONTHS,
     function (month, cb) {
       handleReceiptsForMonth(jar, month, formConfig, cb);

lib/client/auth.js

@@ -44,7 +44,7 @@ var auth = function auth(jar, form, token, authRequestConfig, callback) {
   };
 
   try {
-    request(opt, function (error, response, body) {
+    return request(opt, function (error, response, body) {
 
       if (error) {
         logger.info('error on auth: ', error);

lib/client/createTicket.js

@@ -82,7 +82,7 @@ var sendLotteryTicketRequest = function sendLotteryTicketRequest(jar, token, cap
   };
 
   try {
-    request(opt, function (error, response, body) {
+    return request(opt, function (error, response, body) {
 
       if (error) {
         logger.info('error on sendLotteryTicketRequest: ', error);
@@ -131,7 +131,7 @@ var sendCaptchaRequest = function sendCaptchaRequest(jar, token, captcha, captch
   };
 
   try {
-    request(opt, function (error, response, body) {
+    return request(opt, function (error, response, body) {
 
       if (error) {
         logger.info('error on sendLotteryTicketRequest: ', error);
@@ -253,7 +253,7 @@ var sendLotteryTicket = function sendLotteryTicket(ticketRequest, options, callb
       createTicketsRequestConfig = extend(createTicketsRequestConfig, {url: data.url});
     }
 
-    sendCaptchaRequest(jar, data.token, data.captcha, captchaRequestConfig, function (captchaErr, captchBody) {
+    return sendCaptchaRequest(jar, data.token, data.captcha, captchaRequestConfig, function (captchaErr, captchBody) {
       if (captchaErr) {
         logger.error('sendCaptchaRequest returned with error: ', captchaErr);
         return callback(captchaErr);

lib/client/getTicket.js

@@ -42,7 +42,7 @@ var getLotteryTicketRequest = function getLotteryTicketRequest(jar, token, id, t
   };
 
   try {
-    request(opt, function (error, response, body) {
+    return request(opt, function (error, response, body) {
 
       if (error) {
         logger.info('error on getLotteryTicketRequest: ', error);

lib/client/main.js

@@ -26,7 +26,7 @@ var getMainPage = function getMainPage(jar, options, callback) {
   };
 
   try {
-    request(opts, function (error, response, body) {
+    return request(opts, function (error, response, body) {
       if (error) {
         logger.info('error on getMainPage: ', error);
         return callback(new ServiceUnavailableError('Unable to create receipt'));

lib/client/results.js

@@ -32,7 +32,7 @@ var getResultsRequest = function getResultsRequest(jar, page, formConfig, callba
   };
 
   try {
-    request(opt, function (error, response, body) {
+    return request(opt, function (error, response, body) {
 
       if (error) {
         logger.info('error on getResultsRequest: ', error);
@@ -110,7 +110,7 @@ var handleResults = function handleResults(jar, formConfig, callback) {
   var collection = [];
   var page = 0;
 
-  async.forever(
+  return async.forever(
     function (cb) {
       page++;
       buildList(jar, page, formConfig, function (err, list) {

lib/client/updateTicket.js

@@ -91,7 +91,7 @@ var updateLotteryTicketRequest = function updateLotteryTicketRequest(jar, token,
   };
 
   try {
-    request(opt, function (error, response, body) {
+    return request(opt, function (error, response, body) {
 
       if (error) {
         logger.info('error on updateLotteryTicketRequest: ', error);

package.json

@@ -1,14 +1,14 @@
 {
   "name": "receipts-lottery-client",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "Receipts lottery client",
   "main": "./index.js",
   "dependencies": {
     "assert-plus": "1.0.0",
     "async": "2.0.1",
     "cheerio": "0.20.0",
     "moment-timezone": "0.5.5",
-    "receipts-model": "1.5.1",
+    "receipts-model": "1.5.3",
     "request": "2.74.0",
     "winston": "2.2.0",
     "winston-loggly": "1.3.1"
@@ -45,6 +45,6 @@
     "node": ">=6.2.1"
   },
   "readmeFilename": "README.md",
-  "_id": "receipts-lottery-client@1.3.0",
-  "_from": "receipts-lottery-client@^1.3.0"
+  "_id": "receipts-lottery-client@1.3.1",
+  "_from": "receipts-lottery-client@^1.3.1"
 }