Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] - Compatibility with Image Receiver node (Impact Pack) #17

Closed
alessandroperilli opened this issue Nov 3, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@alessandroperilli
Copy link

Summary

I'm considering different approaches to reduce the number of wires in the AP Workflows without sacrificing understandability of the information flow.

Among the other things, I'm evaluating the use of Impact Pack's Image Sender and Image Receiver nodes.

I would place an Image Sender node after each image generation node (e.g., KSampler, Detailers) and an Image Receiver node just before every SD Prompt Saver node.

My test shows that the latter don't play well together.

After a KSampler node generates the image, it passes it to the Image Sender node, which correctly passes it to the Image Receiver node. However, the Image Receiver node doesn't seem to pass the image to the SD Prompt Saver node as expected:

Screenshot 2023-11-03 at 13 22 34

I am not married to the idea of using Impact Pack's Image Sender/Receiver nodes at all costs. I'd just like to have the SD Prompt Saver to wirelessly receive the image to save, if possible.

Basic Example

See screenshot.

Reference Issues.

No response

@alessandroperilli alessandroperilli added the question Further information is requested label Nov 3, 2023
@receyuki receyuki added enhancement New feature or request and removed question Further information is requested labels Nov 14, 2023
@receyuki
Copy link
Owner

In my tests, everything is working fine, at least the Prompt Saver performs the same as the built-in Saver.

I guess what you mean by 'don't play well together' is that the Saver only updates the image from the first generation after generating the second one. But even when connecting the image receiver to the built-in Saver, this behavior still occurs. So, it seems to be a characteristic of the image receiver rather than something caused by the Saver.

@alessandroperilli
Copy link
Author

alessandroperilli commented Nov 21, 2023

That is correct. I wrongly assumed that the behavior was caused by an incompatibility with the SD Prompt Saver. I should have checked the default saver before opening this issue. I'll be more mindful in the future. Thanks for testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants