Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple XY LineChart support #1

Closed
Cloudo opened this issue Jan 15, 2016 · 3 comments
Closed

Multiple XY LineChart support #1

Cloudo opened this issue Jan 15, 2016 · 3 comments

Comments

@Cloudo
Copy link
Contributor

Cloudo commented Jan 15, 2016

I really impressed by your work.
Is there any support for LineChart to generate lines with not equal sets of x coordinates?

Example: http://c3js.org/samples/simple_xy_multiple.html
Thanks!

@xile611
Copy link
Member

xile611 commented Jan 16, 2016

@Cloudo
Thank you very much!
Recharts is not prefect yet. util now, recharts do not support XY LineChart of C3 yet.
We will consider about XY LineChart.

@xile611
Copy link
Member

xile611 commented Jan 21, 2016

@Cloudo
I think XY LineChart of C3 is much more like ScatterChart with line jointed by all points.
Add the points in the demo of C3 are ordered by x-coordinate.
So we add curve in scatter, and the type of line can by 'joint' and 'fitting'.
The 'joint' curve in scatter just joint all the points.
The 'fitting' curve is more difficult which we will support in the future.

Maybe you can look for the demo in ScatterChart.

@Cloudo
Copy link
Contributor Author

Cloudo commented Jan 21, 2016

Thank you for adding ScatterChart example. It is exactly what I was looking for.

@Cloudo Cloudo closed this as completed Jan 21, 2016
xile611 pushed a commit that referenced this issue Nov 7, 2016
xile611 pushed a commit that referenced this issue Oct 24, 2017
Fix issue in Brush where updateScale executed setState in constructor
xile611 pushed a commit that referenced this issue Jan 18, 2018
xile611 pushed a commit that referenced this issue Jul 19, 2018
I’m working on a chart with several reference areas, some of which extend past the canvas bounds. Though I want to draw the part of the reference area that lies on the canvas, it doesn’t make sense to draw the part that spills out.

It's possible to grow the canvas to accommodate the reference area by specifying `alwaysShow`. Though after thinking about this for a while, it seems that _both_ these things should be possible: to show reference items which are partly off the canvas, and to extend the chart domain to accommodate reference items. This deprecates the `alwaysShow` prop, and adds an `ifOverflow` prop which supports four values:

- `ifOverflow="discard"` (default) – If the reference item falls partly outside the canvas, don't display it. This is the old default.
- `ifOverflow="extendDomain"` – If the reference item falls partly outside the canvas, extend the domain so it fits. This is the old `alwaysShow` behavior.
- `ifOverflow="clip"` – If the reference item falls partly outside the canvas, clip it to the canvas.
- `ifOverflow="keep"` – If the reference item falls partly outside the canvas, draw it anyway.
xile611 pushed a commit that referenced this issue Aug 8, 2019
xile611 pushed a commit that referenced this issue Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants