React 16.9 - Warning: componentWillMount has been renamed, and is not recommended for use.

[SCasarotto]

Do you want to request a feature or report a bug?

Reporting a bug. This should simply require a small code update if we want to leave the unsafe lifecycle methods. That something I can make a PR for but I didn't know if this would be good time to move away from these lifecycle methods all together.

What is the current behavior?

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: http://jsfiddle.net/ndLhnegs/).

Create React Project with React@16.9 or greater and then install recharts and attempt to render a chart.

What is the expected behavior?

No warnings.

Which versions of Recharts, and which browser / OS are affected by this issue? Did this work in previous versions of Recharts?

Recharts@1.7.0

[avindra]

componentWillMount and componentWillReceiveProps will be removed in future React.

The maintainer is looking for contribs #1833

I'm curious if React 16 will be the supported target. If so, then we can remove /replace all the deprecated lifecycle methods.

[avindra]

https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#gradual-migration-path

React 16.3 introduces the UNSAFE_ prefix, and 17 will remove it. So, it seems like minimum required React for all consumers changing to 16.3 may be required to move forward. BC break, maybe major version bump it too.

[semoal]

Hi guys, I'm glad to help with this "small" code update.
We have: 14 componentWillReceiveProps, and just one componentWillMount.

componentWillMount could be easily fixed with a constructor initialization or possibly with componentDidMount(not quite sure about this)

componentWillReceiveProps, it's a little more complicated, we should check if they perform a side effect, in that case use componentDidUpdate, if not use memoization.

• Area
• Bar
• Brush
• Line
• Scatter
• generateCategorialChart
• Sankey
• Treemap
• Text
• Funnel
• Pie
• Radar
• RadialBar
• AnimationDecorator

[damianobarbati]

@semoal actually the ideal solution in the long term is not to move to componentDidUpdate but to move to hooks and effects.

That's a clear path and future-proof approach, but I well understand that brings a lot of codebase rewrite.

[paramsinghvc]

Till the time you aren't moving recharts to hooks, at least, these unsafe methods need to be refactored, they show long warnings in the console.

[cmpaul]

I agree with @paramsinghvc , maybe do an interim fix and plan for a larger refactor in the coming major release?

[ro-savage]

@damianobarbati - Hooks aren't the only way to do things. There are still things that require lifecycle methods, and there is no current plans to depreciate the current lifecycle methods. They are used extensively within the Facebook codebase.

Updating some/all the components to hooks may help simplify some of the components, but isn't need at all for React 17 compatibility.

The main issue here is @xile611 is asking for maintainers (which is fine) but hasn't appointed anyone yet and isn't around to approve PRs.

[timneyens]

Thanks for merging @xile611. Sadly I am still getting an error on one of the dependencies of recharts. It seems the Animate component from react-smooth still has a componentWillReceiveProps. There is a PR on the react-smooth library from recharts: recharts/react-smooth#29
Can this be merged and updated as well?

[Babettestam]

Also still having the warning after updating to the latest version (1.8.3). Seems to be when using the ComposedChart.

[Chiiip]

I am facing the same issue, with recharts@1.8.5.

[mwskwong]

I am facing the same issue, with recharts@1.8.5.

The maintainer has had tried to migrate the deprecated lifecycles to others like componentDidUpdate in version 1.8.0 - 1.8.2. Yet this causes lots of unexpected behaviours since the lifecycles have different behaviours (e.g. even though it is recommended to migrate fromcomponentWillUpdate to componentDidUpdate, they behave very differently).

The changes have ultimately reverted in a later release and a full conversion is planned but will take quite an amount of time.

[Chiiip]

Considering that changing all of these lifecycle methods it's not that easy/quick, i would suggest, for now, the addition of the UNSAFE_ prefix to every method call. I believe it's a simpler thing to do.

That way, we get rid of the warnings with no major changes in the codebase and when React 17 is released, at least the deprecation of these methods won't be a breaking change, even though they would need to be refactored later.

UPDATE: I just noticed that #1905 already applied this fix and has been merged.

[mguida22]

It looks like this was fixed in #1905 then rolled back due to a problem supporting react@15 with the UNSAFE_ prefix (8ae2390).

Is there any path forward to resolve these warnings in react@16 that is still compatible with react@15 @xile611?

I'd be happy to contribute a PR with a bit of guidance on how to best resolve this.

[amirburbea]

Can we drop support for react 15

…

On Tue, Oct 29, 2019, 2:19 PM Mike Guida ***@***.***> wrote: It looks like this was fixed in #1905 <#1905> then rolled back due to a problem supporting ***@***.*** with the UNSAFE_ prefix (8ae2390 <8ae2390> ). Is there any path forward to resolve these warnings in ***@***.*** that is still compatible with ***@***.*** @xile611 <https://github.com/xile611>? I'd be happy to contribute a PR with a bit of guidance on how to best resolve this. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1835?email_source=notifications&email_token=AAQGPCR2ZW6AOUAZCDLJ45DQRB5E3A5CNFSM4IKUYUUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECRSG3Y#issuecomment-547562351>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQGPCU7T7NXITCRYEZY32LQRB5E3ANCNFSM4IKUYUUA> .

[josephmaxim]

Still getting the warning when using ComposedChart, Line components.

[mwskwong]

It looks like this was fixed in #1905 then rolled back due to a problem supporting react@15 with the UNSAFE_ prefix (8ae2390).

@josephmaxim Of course you do, did you even read the posts above?

[axhamre]

Perhaps reopen the issues as it's resurfaced?

[damianobarbati]

Yes, seeing this again

[mikefrancis]

It's a bit hacky and I have no idea how safe this is but this seems to be fixed in the v2 beta:

yarn add recharts@v2.0.0-beta.1

or

npm install recharts@v2.0.0-beta.1

[avindra]

@mikefrancis probably safe. we should all test and report any issues.

the beta also fixes use of core-js 2.x (whereas create-react-app and other modern build tools tend to use 3.x now).

[mikefrancis]

@avindra hopefully v2 will be released soon then 🤞

[oneillsp96]

any status updates on a stable v2 release date?