Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3 dependencies alignement issue #2343

Closed
jmfrancois opened this issue Dec 17, 2020 · 1 comment
Closed

D3 dependencies alignement issue #2343

jmfrancois opened this issue Dec 17, 2020 · 1 comment

Comments

@jmfrancois
Copy link
Contributor

What is the current behavior?

Current main branch shows recharts rely on d3-* packages. This is nice so you just embed what you need.
But please take care of thoses packages wich has a known good set of versions documented in d3 it self:

So if we pay attention to it, recharts use d3-scale 3 which is a d3 6.x release. but all other d3- package are in 1.x which is d3 v5 release. So we have conflict which results in multiple versions of the same libraries:

Screen Shot 2020-12-17 at 10 21 54

What is the expected behavior?

We should know which major version of d3 recharts is relying on and do not have multiple versions of the same libraries.

Which versions of Recharts, and which browser / OS are affected by this issue? Did this work in previous versions of Recharts?

2.0.0-beta

@jmfrancois
Copy link
Contributor Author

fixed by #2349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant