Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip first render #4424

Closed
Kaiyrgali opened this issue Apr 12, 2024 · 7 comments
Closed

Tooltip first render #4424

Kaiyrgali opened this issue Apr 12, 2024 · 7 comments
Labels
bug General bug label

Comments

@Kaiyrgali
Copy link

Kaiyrgali commented Apr 12, 2024

@ckifer Hi! Thank you very much for your work, it is very important for us

We noticed another problem in the new version (we don’t know in which version this happened, but version 2.0.6 does not have this problem)

When a Tooltip has isAnimationActive={false} and content arguments, the first render of the Tooltip is always in the corner of the chart.

Our tests make screenshot and detect the incorrect position of the tooltip
image

At the same time, all the correct arguments come to the tooltip props and it is not possible to cancel the incorrect position of the tooltip

https://codesandbox.io/p/sandbox/recharts-tooltip-problem-24ff35

image

@ckifer
Copy link
Member

ckifer commented Apr 12, 2024

Hey @Kaiyrgali

This issue is similar #4338 (comment)

Also not sure when this became an issue, but I'll try to pin down when it did since this has been reported more than once.
Looks like in your case its pretty much tied to isAnimationActive

@ckifer
Copy link
Member

ckifer commented Apr 12, 2024

Looks like this occurred between 2.11 and 2.12 - can you try to install 2.11 and see if you experience the issue?

@ckifer ckifer added the bug General bug label label Apr 12, 2024
HHongSeungWoo added a commit to HHongSeungWoo/recharts that referenced this issue Apr 13, 2024
HHongSeungWoo added a commit to HHongSeungWoo/recharts that referenced this issue Apr 13, 2024
HHongSeungWoo added a commit to HHongSeungWoo/recharts that referenced this issue Apr 13, 2024
@Kaiyrgali
Copy link
Author

Looks like this occurred between 2.11 and 2.12 - can you try to install 2.11 and see if you experience the issue?

@ckifer version "2.11.0" has the same problem (

@ckifer
Copy link
Member

ckifer commented Apr 13, 2024

Hmm weird why I couldn't reproduce. But try 2.9.3, I think we tracked it to 2.10 and above

HHongSeungWoo added a commit to HHongSeungWoo/recharts that referenced this issue Apr 14, 2024
This reverts commit b7373e6.
@PrabhaShanker
Copy link

this is an old issue, I have noticed the same in 2.4.5

@ckifer
Copy link
Member

ckifer commented Apr 15, 2024

Old as in pre-2.0.6? Or between the two somewhere?

I can't reproduce in 2.9.3 - if you can please feel free to make and share a codesandox, thanks!

@ckifer
Copy link
Member

ckifer commented Apr 21, 2024

fixed in 2.12.6

@ckifer ckifer closed this as completed Apr 21, 2024
pyyding added a commit to pyyding/ui that referenced this issue May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug General bug label
Projects
None yet
Development

No branches or pull requests

3 participants