Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie chart breaks updating from 0.22.3 to 0.22.4 #717

Closed
ciaoben opened this issue Jun 1, 2017 · 6 comments
Closed

Pie chart breaks updating from 0.22.3 to 0.22.4 #717

ciaoben opened this issue Jun 1, 2017 · 6 comments

Comments

@ciaoben
Copy link

ciaoben commented Jun 1, 2017

Updating to version 0.22.3 to version 0.22.4 breaks this chart.

            <PieChart width={330} height={250}>
              <Tooltip />
              <Pie
                data={quotaData}
                outerRadius={100}
                dataKey="email prova"
                innerRadius={30}
                fill="#8884d8"
                paddingAngle={1}
                label={({ value, date }) => `${date}GB`}
              >
                {quotaData.map((entry, index) => (
                  <Cell key={`cell-${index}`} fill={COLORS[index]} />
                ))}
              </Pie>
            </PieChart>

It doesn't render anymore and gives no errors.
Am I missing something? I see nothing related on the changelog.

It asks me for a dataKey prop on the <Pie> component to be required, but even adding it, it does not render.

Meanwhile, I will try to find out what happen and will report here more details if needed.

@wesbos
Copy link

wesbos commented Jun 1, 2017

None of the pie charts are working on the website right now too, is this related?

@mattmast
Copy link

mattmast commented Jun 1, 2017

I have the same question as wesbos.

@pbdm
Copy link

pbdm commented Jun 2, 2017

have got the seme issue, on version 1.0.0-alpha.0

@pbdm
Copy link

pbdm commented Jun 2, 2017

seems that Pie has change it's props, add dataKey slove the problem
if the data is like

const data02 = [{name: 'A1', value: 100},
                    {name: 'A2', value: 300},
                   {name: 'B1', value: 100},
                   {name: 'B2', value: 80},
                   {name: 'B3', value: 40},
                   {name: 'B4', value: 30},
                   {name: 'B5', value: 50},
                  {name: 'C1', value: 100},
                  {name: 'C2', value: 200},
                   {name: 'D1', value: 150},
                   {name: 'D2', value: 50}]

the dateKey could be value

69a7676#diff-777cd5e98eb540b968c2d6f07ce22271R146

@ninahaack
Copy link

I got the same errors. Putting value as datekey following the example of @pbdm worked, but onMouseEnter is not working.

@oliverwatkins
Copy link

None of the pie charts work for me as well

raviteja83 pushed a commit to raviteja83/recharts that referenced this issue Sep 18, 2017
raviteja83 added a commit to raviteja83/recharts that referenced this issue Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants