-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResponsiveContainer listen to parent element instead of the window #105
Conversation
@zvictor How about the problem of initial width and height you have mentioned in react-container-dimensions#1 |
I just analyzed it again and made a new PR there 🍻 |
Great! Thanks! |
@zvictor I've merged it. Please test it with |
@okonet I tried locally with |
Im having issues with the ResponsiveContainer. Not sure if related to same issues.
|
@sbehrends try removing |
@okonet nope. The issue also occurred with a simpler example.
|
@sbehrends Can you show your complete code in JSFiddle? |
@xile611 closing a PR and pushing the changes as if it was your work is definitely not a good way to keep the community engaged in contributing to your project. Getting credits for my contribution is the only payment I expected to get for spending time publishing my changes. |
@zvictor I apologize for my reckless behaviour, I should communicate with you if you are still willing to update the commits. |
fix #104