Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ResponsiveContainer ref #2784

Closed
wants to merge 1 commit into from
Closed

Fixed ResponsiveContainer ref #2784

wants to merge 1 commit into from

Conversation

mrskiro
Copy link
Contributor

@mrskiro mrskiro commented Feb 15, 2022 •
edited

Until now, if user wanted to access a ref object, they had to use ref.current.current.

This was unfriendly and not clear, so I fixed it.

@KittyGiraudel
Copy link

KittyGiraudel commented Mar 20, 2022 •
edited

This would be a breaking change though, so I guess it would have to wait for a major version.

@ckifer ckifer added P2 Feature requests or future priority issues enhancement Enhancement to a current API labels Dec 14, 2022
@ckifer
Copy link
Member

ckifer commented Dec 14, 2022

Added some labels, most likely fine to add this as a breaking change in 3 if we ever get there

@ckifer ckifer added this to the Recharts@3.0 milestone Dec 23, 2022
@nikolasrieble nikolasrieble added the breaking change Use this label to indicate a breaking change in the Recharts API label Jan 5, 2023
@constgen
Copy link

Not this change is breaking. But this bug is a breaking issue.

@ckifer
Copy link
Member

ckifer commented Feb 17, 2023

Not sure what you mean. Those that use those functionality have this referenced a certain way. If we change it in a minor or patch release it will break them.

@mrskiro
Copy link
Contributor Author

mrskiro commented Mar 6, 2023

@ckifer
Do you plan to merge these?
I recently had plans to UPGRADE my recharts and was reminded of this PR.

@ckifer
Copy link
Member

ckifer commented Mar 6, 2023

Yeah but it's a breaking change, so not until 3.x. Which is still timeframe TBD as we gather other breaking changes

@mrskiro
Copy link
Contributor Author

mrskiro commented Mar 6, 2023

I understand.
Thanks for all the maintenance！

@ckifer ckifer mentioned this pull request Aug 25, 2023
Closed
@ckifer ckifer mentioned this pull request Oct 22, 2023
Merged
9 tasks
@ckifer
Copy link
Member

ckifer commented Oct 26, 2023

Going to close this PR in favor of re-opening the issue #3718. Harder to keep a PR up to date while waiting for a major version

@ckifer ckifer closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change Use this label to indicate a breaking change in the Recharts API enhancement Enhancement to a current API P2 Feature requests or future priority issues
Projects
Recharts 3.0
Status: Done
Milestone
Recharts@3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mrskiro @KittyGiraudel @ckifer @constgen @nikolasrieble