Skip to content

Fixed ResponsiveContainer ref#2784

Closed
mrskiro wants to merge 1 commit into
recharts:masterfrom
mrskiro:purpleeeee-fix-container-ref
Closed

Fixed ResponsiveContainer ref#2784
mrskiro wants to merge 1 commit into
recharts:masterfrom
mrskiro:purpleeeee-fix-container-ref

Conversation

@mrskiro
Copy link
Copy Markdown
Contributor

@mrskiro mrskiro commented Feb 15, 2022

Until now, if user wanted to access a ref object, they had to use ref.current.current.

This was unfriendly and not clear, so I fixed it.

@KittyGiraudel
Copy link
Copy Markdown

KittyGiraudel commented Mar 20, 2022

This would be a breaking change though, so I guess it would have to wait for a major version.

@ckifer ckifer added P2 Feature requests or future priority issues enhancement Enhancement to a current API labels Dec 14, 2022
@ckifer
Copy link
Copy Markdown
Member

ckifer commented Dec 14, 2022

Added some labels, most likely fine to add this as a breaking change in 3 if we ever get there

@ckifer ckifer added this to the Recharts@3.0 milestone Dec 23, 2022
@nikolasrieble nikolasrieble added the breaking change Use this label to indicate a breaking change in the Recharts API label Jan 5, 2023
@constgen
Copy link
Copy Markdown

Not this change is breaking. But this bug is a breaking issue.

@ckifer
Copy link
Copy Markdown
Member

ckifer commented Feb 17, 2023

Not sure what you mean. Those that use those functionality have this referenced a certain way. If we change it in a minor or patch release it will break them.

@mrskiro
Copy link
Copy Markdown
Contributor Author

mrskiro commented Mar 6, 2023

@ckifer
Do you plan to merge these?
I recently had plans to UPGRADE my recharts and was reminded of this PR.

@ckifer
Copy link
Copy Markdown
Member

ckifer commented Mar 6, 2023

Yeah but it's a breaking change, so not until 3.x. Which is still timeframe TBD as we gather other breaking changes

@mrskiro
Copy link
Copy Markdown
Contributor Author

mrskiro commented Mar 6, 2023

I understand.
Thanks for all the maintenance!

@ckifer
Copy link
Copy Markdown
Member

ckifer commented Oct 26, 2023

Going to close this PR in favor of re-opening the issue #3718. Harder to keep a PR up to date while waiting for a major version

@ckifer ckifer closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Use this label to indicate a breaking change in the Recharts API enhancement Enhancement to a current API P2 Feature requests or future priority issues

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants