Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BarChart: Finish migration of test to jest #3111

Merged
merged 2 commits into from
Dec 22, 2022
Merged

BarChart: Finish migration of test to jest #3111

merged 2 commits into from
Dec 22, 2022

Conversation

nikolasrieble
Copy link
Contributor

Jest Migration:

Following the pattern of my previous PR #3106, I:

  • remove redundant tests
  • fix issues in the jest test
  • implement a missing test that was commented out.

@nikolasrieble
Copy link
Contributor Author

Wondering: Why is the PR Template not working? 🤔

@ckifer
Copy link
Member

ckifer commented Dec 22, 2022

re-PR template looks like gh looks for a different file name. pull_request_template.md

ckifer
ckifer approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@ckifer ckifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Lets keep this up and also attempt to move these to TypeScript when we can

@ckifer ckifer merged commit b341920 into recharts:master Dec 22, 2022
@nikolasrieble nikolasrieble deleted the nikolas.BarChartSpec.cleanup branch December 23, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckifer ckifer ckifer approved these changes

@arcthur arcthur Awaiting requested review from arcthur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikolasrieble @ckifer