Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AreaChart: Respect baseValue of AreaChart, but allow override from Area #3140

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

nikolasrieble
Copy link
Contributor

Fix a bug, introduced in #3013, which neglects to respect the AreaChart baseValue and thereby breaks existing charts.

Related Issue

#3051

How Has This Been Tested?

I tested the change locally by running the demo project, verifying that the baseValue of the AreaChart is effective by itself, and that overriding it per Area component is possible.

Screenshots (if appropriate):

Screenshot 2023-01-04 at 15 20 14

Screenshot 2023-01-04 at 15 20 04

Screenshot 2023-01-04 at 15 19 53

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nikolasrieble
Copy link
Contributor Author

nikolasrieble commented Jan 4, 2023

TODO:

  • Add test to document the target behaviour and prevent future deviation / breaking.
  • Document feature on the website.

Copy link
Member

@ckifer ckifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good to me! Easy fix

@nikolasrieble Question would be do you want me to merge this now or wait for the TODO items?

@nikolasrieble
Copy link
Contributor Author

I guess as this is a fix restoring a previously existing functionality, this is good to go.
Tests and docs are missing across the bench either way.

@ckifer ckifer merged commit c07f762 into recharts:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants