Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(JestMigration): convert CartesianGridSpec #3199

Merged
merged 3 commits into from
Jan 20, 2023
Merged

test(JestMigration): convert CartesianGridSpec #3199

merged 3 commits into from
Jan 20, 2023

Conversation

proke03
Copy link
Contributor

@proke03 proke03 commented Jan 20, 2023 •
edited

Description

Migrates test/specs/cartesian/CartesianGridSpec.js → test-jest/cartesian/CartesianGrid.spec.tsx

Related Issue

#3186

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@proke03 proke03 changed the title test(jest migration): convert CartesianGridSpec test(JestMigration): convert CartesianGridSpec Jan 20, 2023
nikolasrieble
nikolasrieble approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@nikolasrieble nikolasrieble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

ckifer
ckifer approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@ckifer ckifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckifer ckifer merged commit 7dacd1a into recharts:master Jan 20, 2023
@ckifer ckifer mentioned this pull request Jan 20, 2023
Closed
3 tasks
@proke03 proke03 deleted the test(JestMigration)/convert-CartesianGridSpec branch January 22, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckifer ckifer ckifer approved these changes

@nikolasrieble nikolasrieble nikolasrieble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@proke03 @ckifer @nikolasrieble